Commit Graph
7 Commits
Author SHA1 Message Date
Henrik Ingo 8b14eda98f Broader try-catch for handling impress-console-button disappearance (#652)
The previous attempt at merely reading a property of event.target was
incorrect. It worked at first but errors reappeared later, so must
have been a reace.

This wraps the entire navigation event handlers in the try-catch, and
then checks for the very specific error and suppresses it. Other errors
are rethrown as is.
2018-01-01 16:03:13 +02:00
Henrik Ingo 784a6d245b Also sync js/impress.js / Forgot to run node build.js 2018-01-01 15:32:16 +02:00
Henrik Ingo 729651dd5d Fix lint errors 2018-01-01 15:27:33 +02:00
Henrik Ingo e92e02ccb4 Make impress-console-button actually clickable (#651)
Changed the onclick handler to trigger the impress:console:open event
and not use the impressConsole() global function any more. The latter
is considered deprecated now that impressConsole is integrated into
impress.js itself.

Also catch some errors that appear in event handlers when the target
for the click event was immediately removed from DOM.

Fixes #651
2018-01-01 15:05:55 +02:00
Henrik Ingo df3532085f impressConsole broke init() if root element didn't have id="impress"
Also adds regression tests to prevent this from happening in the future
as well as upgrades karma-chrome-launcher to newest version.

Fixes #654
2017-12-31 14:36:43 +02:00
Henrik Ingo ba1fe7f6d6 Add link to Github release page for downloading stable releases.
Intentionally omitting git checkout <tag> alternative for simplicity.
Those that now how git works, will know it anyway.
2017-12-01 21:48:16 +02:00
Henrik Ingo c5e93f6885 Fix a couple links in README.md 2017-11-12 21:41:13 +02:00