janishutz-legacy/impress.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix form plugin for input fields.

Browse Source 
It turns out input[type=text] will only find input fields where
the type attribute is explicitly set to text, but would skip
fields that left it out and defaulted to type text. This changes
to catch all types of input elements.
This commit is contained in:
Henrik Ingo
2019-01-01 21:40:46 +02:00
parent f6f4a36766
commit 4d3adb09cd
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
js/impress.js
View File

@@ -1628,7 +1628,7 @@
api = event.detail.api;
var gc = api.lib.gc;
var selectors = [ "input[type=text]", "textarea", "select", "[contenteditable=true]" ];
var selectors = [ "input", "textarea", "select", "[contenteditable=true]" ];
for ( var selector of selectors ) {
var elements = document.querySelectorAll( selector );
if ( !elements ) {
@@ -1893,7 +1893,7 @@
document.addEventListener( "keyup", function( event ) {
if ( event.keyCode === 72 ) { // "h"
if ( event.keyCode === 72 || event.keyCode === 191 ) { // "h" || "?"
event.preventDefault();
toggleHelp();
}
@@ -3203,7 +3203,6 @@
if ( event.shiftKey ) {
switch ( event.keyCode ) {
case 9: // Shift+tab
case 32: // Shift+space
api.prev();
break;
}

2
src/plugins/form/form.js
View File

@@ -32,7 +32,7 @@
api = event.detail.api;
var gc = api.lib.gc;
var selectors = [ "input[type=text]", "textarea", "select", "[contenteditable=true]" ];
var selectors = [ "input", "textarea", "select", "[contenteditable=true]" ];
for ( var selector of selectors ) {
var elements = document.querySelectorAll( selector );
if ( !elements ) {