From e1786e38e91ae445bb1caf968907292ec247f80c Mon Sep 17 00:00:00 2001 From: Bartek Szopka Date: Thu, 8 Mar 2012 16:20:33 +0100 Subject: [PATCH 1/3] couple of typos and inline script warning in courtesy of @gustaff-weldon --- index.html | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 3660011..c175bce 100644 --- a/index.html +++ b/index.html @@ -273,6 +273,15 @@ This class is used by this hint below. Check CSS file to see how it's shown with delayed CSS animation. + ... + + And when it comes to this piece of JavaScript below ... kids, don't do this at home ;) + It's just a quick and dirty workaround to get different content for touch devices. + In a real world it should be at least placed in separate JS file ... and the touch content should be + probably just hidden somewhere in HTML, not hard-coded in the script. + + Just sayin' ;) + -->

Use a spacebar or arrow keys to navigate

@@ -294,8 +303,8 @@ if ("ontouchstart" in document.documentElement) { You also need to call a `impress()` function to initialize impress.js presentation. And you should do it in the end of your document. Not only because it's a good practice, but also - because I should be done when the whole document is ready. - Of course you can wrap it in any kind of "DOM ready" event, but I was to lazy to do so ;) + because it should be done when the whole document is ready. + Of course you can wrap it in any kind of "DOM ready" event, but I was too lazy to do so ;) --> From c382aeb71081138e461685d5e7edcaeca488c821 Mon Sep 17 00:00:00 2001 From: Bartek Szopka Date: Thu, 8 Mar 2012 20:20:10 +0100 Subject: [PATCH 2/3] fixing broken event delegation when clicking on body - issue #113 --- js/impress.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/impress.js b/js/impress.js index d9bbec2..0d8ba7d 100644 --- a/js/impress.js +++ b/js/impress.js @@ -371,7 +371,7 @@ // check if event target (or any of its parents is a link) var target = event.target; while ( (target.tagName != "A") && - (target != document.body) ) { + (target != document.documentElement) ) { target = target.parentNode; } @@ -395,7 +395,7 @@ var target = event.target; // find closest step element while ( !target.classList.contains("step") && - (target != document.body) ) { + (target != document.documentElement) ) { target = target.parentNode; } From 40acfb1a7299058fbc23ea43d0a81ca2abd9907c Mon Sep 17 00:00:00 2001 From: Bartek Szopka Date: Thu, 8 Mar 2012 20:23:33 +0100 Subject: [PATCH 3/3] now Firefox 3.6 correctly Yoda should parse --- index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.html b/index.html index c175bce..0529155 100644 --- a/index.html +++ b/index.html @@ -11,7 +11,7 @@ .-.'`. ; .'`.-. __ / : ___\ ; /___ ; \ __ ,'_ ""--.:__;".-.";: :".-.":__;.--"" _`, - :' `.t""--.. '<@.`;_ ',@>` ..--""j.' `; + :' `.t""--.. '<@.`;_ ',@:` ..--""j.' `; `:-.._J '-.-'L__ `-- ' L_..-;' "-.__ ; .-" "-. : __.-" L ' /.------.\ ' J