janishutz-legacy/impress.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

impressConsole broke init() if root element didn't have id="impress"

Browse Source 
Also adds regression tests to prevent this from happening in the future
as well as upgrades karma-chrome-launcher to newest version.

Fixes #654
This commit is contained in:
Henrik Ingo
2017-12-31 14:36:43 +02:00
parent cd499ed8cf
commit df3532085f
11 changed files with 202 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/navigation/navigation_tests.js
View File

@@ -155,8 +155,8 @@ QUnit.test( "Navigation Plugin - No-op tests", function( assert ) {
root.addEventListener( "impress:stepleave", assertStepLeaveWrapper );
// These are no-op actions, we're already in step-1 -----------------------//
assert.ok( iframeWin.syn.click( "step-1", {} ),
"Click on step that is currently active, should do nothing." );
//assert.ok( iframeWin.syn.click( "step-1", {} ),
// "Click on step that is currently active, should do nothing." );
assert.ok( iframeWin.syn.click( "linktofirst", {} ),
"Click on link pointing to step that is currently active, should do nothing." );