From d6c6cd47c2e3252b29adec66e097759456c8ab84 Mon Sep 17 00:00:00 2001 From: Henrik Ingo Date: Wed, 1 Nov 2017 15:00:03 +0200 Subject: [PATCH] Change gc.lib.addCallback to gc.lib.pushCallback (#626) --- js/impress.js | 22 +++++++++++----------- src/lib/gc.js | 8 ++++---- src/plugins/autoplay/autoplay.js | 2 +- src/plugins/help/help.js | 2 +- src/plugins/mobile/mobile.js | 2 +- src/plugins/mouse-timeout/mouse-timeout.js | 2 +- src/plugins/progress/progress.js | 2 +- src/plugins/rel/rel.js | 2 +- src/plugins/toolbar/toolbar.js | 2 +- 9 files changed, 22 insertions(+), 22 deletions(-) diff --git a/js/impress.js b/js/impress.js index bc9a8b1..78d4cbc 100644 --- a/js/impress.js +++ b/js/impress.js @@ -971,12 +971,12 @@ pushEventListener( target, type, listenerFunction ); }; - // `addCallback` If the above utilities are not enough, plugins can add their own callback + // `pushCallback` If the above utilities are not enough, plugins can add their own callback // function to do arbitrary things. - var addCallback = function( callback ) { + var pushCallback = function( callback ) { callbackList.push( callback ); }; - addCallback( function( rootId ) { resetStartingState( rootId ); } ); + pushCallback( function( rootId ) { resetStartingState( rootId ); } ); // `teardown` will // - execute all callbacks in LIFO order @@ -1009,7 +1009,7 @@ appendChild: appendChild, pushEventListener: pushEventListener, addEventListener: addEventListener, - addCallback: addCallback, + pushCallback: pushCallback, teardown: teardown }; roots[ rootId ] = lib; @@ -1294,7 +1294,7 @@ addToolbarButton( toolbar ); } - api.lib.gc.addCallback( function() { + api.lib.gc.pushCallback( function() { clearTimeout( timeoutHandle ); } ); @@ -1911,7 +1911,7 @@ // Regster callback to empty the help div on teardown var api = e.detail.api; - api.lib.gc.addCallback( function() { + api.lib.gc.pushCallback( function() { window.clearTimeout( timeoutHandle ); helpDiv.style.display = ""; helpDiv.innerHTML = ""; @@ -2728,7 +2728,7 @@ // Unset all this on teardown var api = event.detail.api; - api.lib.gc.addCallback( function() { + api.lib.gc.pushCallback( function() { document.body.classList.remove( "impress-mobile" ); var prev = document.getElementsByClassName( "prev" )[ 0 ]; var next = document.getElementsByClassName( "next" )[ 0 ]; @@ -2825,7 +2825,7 @@ show(); // Unset all this on teardown - gc.addCallback( function() { + gc.pushCallback( function() { window.clearTimeout( timeoutHandle ); document.body.classList.remove( "impress-mouse-timeout" ); } ); @@ -3150,7 +3150,7 @@ root = event.target; getSteps(); var gc = event.detail.api.lib.gc; - gc.addCallback( function() { + gc.pushCallback( function() { stepids = []; if ( progressbar ) { progressbar.style.width = ""; @@ -3336,7 +3336,7 @@ // Register teardown callback to reset the data.x, .y, .z values. document.addEventListener( "impress:init", function( event ) { var root = event.target; - event.detail.api.lib.gc.addCallback( function() { + event.detail.api.lib.gc.pushCallback( function() { var steps = startingState[ root.id ]; var step; while ( step = steps.pop() ) { @@ -3848,7 +3848,7 @@ document.addEventListener( "impress:init", function( event ) { var api = event.detail.api; - api.lib.gc.addCallback( function() { + api.lib.gc.pushCallback( function() { toolbar.innerHTML = ""; groups = []; } ); diff --git a/src/lib/gc.js b/src/lib/gc.js index 3147d7f..9dd76e5 100644 --- a/src/lib/gc.js +++ b/src/lib/gc.js @@ -55,12 +55,12 @@ pushEventListener( target, type, listenerFunction ); }; - // `addCallback` If the above utilities are not enough, plugins can add their own callback + // `pushCallback` If the above utilities are not enough, plugins can add their own callback // function to do arbitrary things. - var addCallback = function( callback ) { + var pushCallback = function( callback ) { callbackList.push( callback ); }; - addCallback( function( rootId ) { resetStartingState( rootId ); } ); + pushCallback( function( rootId ) { resetStartingState( rootId ); } ); // `teardown` will // - execute all callbacks in LIFO order @@ -93,7 +93,7 @@ appendChild: appendChild, pushEventListener: pushEventListener, addEventListener: addEventListener, - addCallback: addCallback, + pushCallback: pushCallback, teardown: teardown }; roots[ rootId ] = lib; diff --git a/src/plugins/autoplay/autoplay.js b/src/plugins/autoplay/autoplay.js index 86dc8eb..4c3e8cc 100644 --- a/src/plugins/autoplay/autoplay.js +++ b/src/plugins/autoplay/autoplay.js @@ -41,7 +41,7 @@ addToolbarButton( toolbar ); } - api.lib.gc.addCallback( function() { + api.lib.gc.pushCallback( function() { clearTimeout( timeoutHandle ); } ); diff --git a/src/plugins/help/help.js b/src/plugins/help/help.js index 4df9492..1c8db43 100644 --- a/src/plugins/help/help.js +++ b/src/plugins/help/help.js @@ -105,7 +105,7 @@ // Regster callback to empty the help div on teardown var api = e.detail.api; - api.lib.gc.addCallback( function() { + api.lib.gc.pushCallback( function() { window.clearTimeout( timeoutHandle ); helpDiv.style.display = ""; helpDiv.innerHTML = ""; diff --git a/src/plugins/mobile/mobile.js b/src/plugins/mobile/mobile.js index 91c6261..b7bcc4b 100644 --- a/src/plugins/mobile/mobile.js +++ b/src/plugins/mobile/mobile.js @@ -51,7 +51,7 @@ // Unset all this on teardown var api = event.detail.api; - api.lib.gc.addCallback( function() { + api.lib.gc.pushCallback( function() { document.body.classList.remove( "impress-mobile" ); var prev = document.getElementsByClassName( "prev" )[ 0 ]; var next = document.getElementsByClassName( "next" )[ 0 ]; diff --git a/src/plugins/mouse-timeout/mouse-timeout.js b/src/plugins/mouse-timeout/mouse-timeout.js index 1c6afd1..342cc38 100644 --- a/src/plugins/mouse-timeout/mouse-timeout.js +++ b/src/plugins/mouse-timeout/mouse-timeout.js @@ -58,7 +58,7 @@ show(); // Unset all this on teardown - gc.addCallback( function() { + gc.pushCallback( function() { window.clearTimeout( timeoutHandle ); document.body.classList.remove( "impress-mouse-timeout" ); } ); diff --git a/src/plugins/progress/progress.js b/src/plugins/progress/progress.js index 85b4d26..8d74dad 100644 --- a/src/plugins/progress/progress.js +++ b/src/plugins/progress/progress.js @@ -19,7 +19,7 @@ root = event.target; getSteps(); var gc = event.detail.api.lib.gc; - gc.addCallback( function() { + gc.pushCallback( function() { stepids = []; if ( progressbar ) { progressbar.style.width = ""; diff --git a/src/plugins/rel/rel.js b/src/plugins/rel/rel.js index c57fe54..105d232 100644 --- a/src/plugins/rel/rel.js +++ b/src/plugins/rel/rel.js @@ -146,7 +146,7 @@ // Register teardown callback to reset the data.x, .y, .z values. document.addEventListener( "impress:init", function( event ) { var root = event.target; - event.detail.api.lib.gc.addCallback( function() { + event.detail.api.lib.gc.pushCallback( function() { var steps = startingState[ root.id ]; var step; while ( step = steps.pop() ) { diff --git a/src/plugins/toolbar/toolbar.js b/src/plugins/toolbar/toolbar.js index aa019b0..5e03d09 100644 --- a/src/plugins/toolbar/toolbar.js +++ b/src/plugins/toolbar/toolbar.js @@ -147,7 +147,7 @@ document.addEventListener( "impress:init", function( event ) { var api = event.detail.api; - api.lib.gc.addCallback( function() { + api.lib.gc.pushCallback( function() { toolbar.innerHTML = ""; groups = []; } );