janishutz-legacy/impress.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Trigger impress:steprefresh for every onStepEnter ( goto() )

Browse Source 
Unlike impress:stepenter, we emit impress:steprefresh event also
when the "entered" step is the current step. This allows plugins
to reload or redraw objects if needed.

(Note that resize plugin already calls goto() on the active element
for similar purposes when it sees a window resize event. Emitting
impress:steprefresh allows other plugins to join in such a refresh,
and also others can call goto() if a refresh is needed.)
This commit is contained in:
Henrik Ingo
2017-10-21 14:02:07 +03:00
parent f0b99f81ac
commit b15b07ef49
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
js/impress.js
View File

@@ -225,11 +225,15 @@
// `onStepEnter` is called whenever the step element is entered // `onStepEnter` is called whenever the step element is entered
// but the event is triggered only if the step is different than // but the event is triggered only if the step is different than
// last entered step. // last entered step.
// We sometimes call `goto`, and therefore `onStepEnter`, just to redraw a step, such as
// after screen resize. In this case - more precisely, in any case - we trigger a
// `impress:steprefresh` event.
var onStepEnter = function( step ) { var onStepEnter = function( step ) {
if ( lastEntered !== step ) { if ( lastEntered !== step ) {
lib.util.triggerEvent( step, "impress:stepenter" ); lib.util.triggerEvent( step, "impress:stepenter" );
lastEntered = step; lastEntered = step;
} }
lib.util.triggerEvent( step, "impress:steprefresh" );
}; };
// `onStepLeave` is called whenever the currentStep element is left // `onStepLeave` is called whenever the currentStep element is left

4
src/impress.js
View File

@@ -225,11 +225,15 @@
// `onStepEnter` is called whenever the step element is entered // `onStepEnter` is called whenever the step element is entered
// but the event is triggered only if the step is different than // but the event is triggered only if the step is different than
// last entered step. // last entered step.
// We sometimes call `goto`, and therefore `onStepEnter`, just to redraw a step, such as
// after screen resize. In this case - more precisely, in any case - we trigger a
// `impress:steprefresh` event.
var onStepEnter = function( step ) { var onStepEnter = function( step ) {
if ( lastEntered !== step ) { if ( lastEntered !== step ) {
lib.util.triggerEvent( step, "impress:stepenter" ); lib.util.triggerEvent( step, "impress:stepenter" );
lastEntered = step; lastEntered = step;
} }
lib.util.triggerEvent( step, "impress:steprefresh" );
}; };
// `onStepLeave` is called whenever the currentStep element is left // `onStepLeave` is called whenever the currentStep element is left